github/amiga-clib2
1
0
Fork 0
mirror of https://github.com/adtools/clib2.git synced 2025-12-08 14:59:05 +00:00
Code Issues Releases Wiki Activity

- Resolved the vulnerability by caching the socket descriptor while the

Browse Source 
stdio data is still locked.


git-svn-id: file:///Users/olsen/Code/migration-svn-zu-git/logical-line-staging/clib2/trunk@15037 87f5fb63-7c3d-0410-a384-fd976d0f7a62
This commit is contained in:
Olaf Barthel
2005-10-09 14:48:19 +00:00
parent cb1f1a4a10
commit db9a1c69e5
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
library/socket_accept.c
View File

@ -1,5 +1,5 @@
/*
* $Id: socket_accept.c,v 1.14 2005-10-09 09:05:27 obarthel Exp $
* $Id: socket_accept.c,v 1.15 2005-10-09 14:48:19 obarthel Exp $
*
* :ts=4
*
@ -55,6 +55,7 @@ accept(int sockfd,struct sockaddr *cliaddr,socklen_t *addrlen)
struct fd * new_fd;
int new_fd_slot_number;
int result = ERROR;
LONG socket_fd;
LONG new_socket_fd = -1;
BOOL stdio_locked = FALSE;
@ -93,17 +94,18 @@ accept(int sockfd,struct sockaddr *cliaddr,socklen_t *addrlen)
if(fd == NULL)
goto out;
/* Remember the socket number for later. */
socket_fd = (LONG)fd->fd_DefaultFile;
/* Now let go of the stdio lock, so that the only locking performed
will be done inside the accept() call. Note that this makes the
accept() stub vulnerable: a different Process might be able to
close the socket accept() will wait upon! */
will be done inside the accept() call. */
__stdio_unlock();
stdio_locked = FALSE;
/* Wait for the accept() to complete, then hook up the socket
with a file descriptor. */
PROFILE_OFF();
new_socket_fd = __accept((LONG)fd->fd_DefaultFile,cliaddr,(LONG *)addrlen);
new_socket_fd = __accept(socket_fd,cliaddr,(LONG *)addrlen);
PROFILE_ON();
if(new_socket_fd < 0)