- Add a link for the ledger subfolder in sql-server-samples/README.md at master · Pietervanhove/sql-server-samples (github.com)
- Change the folder name from “sqlledger” to “ledger” (that’s the official feature name now).
- sql-server-samples/README.md at master · Pietervanhove/sql-server-samples (github.com)
o Fix grammar in “The demo in this folder showcases the ledger feature in Azure SQL Database. The demo uses the Contoso HR web application.”
o Are Az PS 5.6, SqlServer 21.1.18245, Bicep 0.4.63, SSMS 18.9.1 the versions you’ve tested with? These are older versions (the same we used when developing the AE demo). Should we recommend using newer versions?
o “The ContosoHR database using General Purpose compute tier, 2 vCores, and the Gen5 hardware generation.”
I’m wondering if there is a better/more economical SLO/SKU we can pick, instead of the 2-core Gen 5 database.
Of course, Basic/Standard would be very cheap, but we probably should promote the new v-core model.
Would serverless be a better option, e.g. “GP_S_Gen5_1”?
o If we change the folder name, change sqlledger to ledger in cd "C:\sql-server-samples\samples\features\security\sql-ledger\azure-sql-database\setup"
o “Open a new InPrivate browser window.” Are these instructions generic enough to accommodate browsers other than Edge?
- sql-server-samples/samples/features/security/contoso-hr-sql-db at master · Pietervanhove/sql-server-samples (github.com)
o This is unrelated to ledger. Could you also remove this folder? It was checked in by mistake when we added the AE demo. It is redundant/not needed.
dependabot[bot]
Pieter
Pedro Lopes
jaszymas