From 6ebb75af42c5b3ed2c1ceaf613f6b0fe697c3027 Mon Sep 17 00:00:00 2001
From: Guillaume-Fourrat <39527431+Guillaume-Fourrat@users.noreply.github.com>
Date: Mon, 14 Oct 2019 10:41:40 +0200
Subject: [PATCH] setup-volumes-agent.sh : Explain need for mount in comments

No code change, just 2 lines of comments pertaining to the seemingly redundant need to mount the folders when they *already* are under the discovery folder.
---
 .../deployment/kubeadm/ubuntu/setup-volumes-agent.sh            | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/samples/features/sql-big-data-cluster/deployment/kubeadm/ubuntu/setup-volumes-agent.sh b/samples/features/sql-big-data-cluster/deployment/kubeadm/ubuntu/setup-volumes-agent.sh
index ef043336..f07d28af 100644
--- a/samples/features/sql-big-data-cluster/deployment/kubeadm/ubuntu/setup-volumes-agent.sh
+++ b/samples/features/sql-big-data-cluster/deployment/kubeadm/ubuntu/setup-volumes-agent.sh
@@ -7,5 +7,7 @@ for i in $(seq 1 $PV_COUNT); do
   vol="vol$i"
   
   mkdir -p /mnt/local-storage/$vol
+  # If wondering why the next code line is needed, see https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner/blob/master/docs/faqs.md#why-i-need-to-bind-mount-normal-directories-to-create-pvs-for-them
+  # Experience showed that the mount need to exist at cluster provision time. The fact they're not put in fstab and will disappear after reboot doesn't seem to be an issue once the K8S PV are created.
   mount --bind /mnt/local-storage/$vol /mnt/local-storage/$vol
 done