From 4924c875e0b3c5cc5bea90c843dcbe255336b3b0 Mon Sep 17 00:00:00 2001
From: Jovan Popovic <jocapc@gmail.com>
Date: Fri, 17 Jan 2020 17:09:57 +0100
Subject: [PATCH] Added comments on valid sample

---
 .../workspace/azuredeploy.json                | 30 ++++++++++++++-----
 .../workspace/azuredeploy.parameters.json     | 14 ++++-----
 2 files changed, 30 insertions(+), 14 deletions(-)

diff --git a/samples/manage/synapse-analytics/workspace/azuredeploy.json b/samples/manage/synapse-analytics/workspace/azuredeploy.json
index 670537dc..06b66aa9 100644
--- a/samples/manage/synapse-analytics/workspace/azuredeploy.json
+++ b/samples/manage/synapse-analytics/workspace/azuredeploy.json
@@ -9,15 +9,22 @@
             "type": "String"
         },
         "defaultDataLakeStorageAccountName": {
-            "type": "String"
+            "type": "String",
+            "metadata": {
+                "description": "Data Lake Storage account that you will use for Synapse Workspace."
+            }
         },
         "defaultDataLakeStorageFilesystemName": {
-            "type": "String"
+            "defaultValue": "workspace",
+            "type": "String",
+            "metadata": {
+                "description": "Container in Data Lake Storage account that you will use for Synapse Workspace."
+            }
         },
         "sqlAdministratorLogin": {
             "type": "String"
         },
-        "sqlAdministratorLoginPassword": {
+        "sqlAdministratorPassword": {
             "type": "SecureString"
         },
         "setWorkspaceIdentityRbacOnFilesystem": {
@@ -37,15 +44,24 @@
         },
         "storageSubscriptionID": {
             "defaultValue": "[subscription().subscriptionId]",
-            "type": "String"
+            "type": "String",
+            "metadata": {
+                "description": "Do not change this value if Data Lake Storage is placed in the same subscription as Synapse Workspace(recommended)."
+            }
         },
         "storageResourceGroupName": {
             "defaultValue": "[resourceGroup().name]",
-            "type": "String"
+            "type": "String",
+            "metadata": {
+                "description": "Do not change this value if Data Lake Storage is placed in the same resource group as Synapse Workspace."
+            }
         },
         "storageLocation": {
             "defaultValue": "[resourceGroup().location]",
-            "type": "String"
+            "type": "String",
+            "metadata": {
+                "description": "Do not change this value if Data Lake Storage is placed in the same region as Synapse Workspace(recommended)."
+            }
         }
     },
     "variables": {
@@ -71,7 +87,7 @@
                     "computeSubnetId": "[parameters('poolSubnetId')]"
                 },
                 "sqlAdministratorLogin": "[parameters('sqlAdministratorLogin')]",
-                "sqlAdministratorLoginPassword": "[parameters('sqlAdministratorLoginPassword')]"
+                "sqlAdministratorLoginPassword": "[parameters('sqlAdministratorPassword')]"
             },
             "resources": [
                 {
diff --git a/samples/manage/synapse-analytics/workspace/azuredeploy.parameters.json b/samples/manage/synapse-analytics/workspace/azuredeploy.parameters.json
index b40cd50d..f8629371 100644
--- a/samples/manage/synapse-analytics/workspace/azuredeploy.parameters.json
+++ b/samples/manage/synapse-analytics/workspace/azuredeploy.parameters.json
@@ -3,19 +3,19 @@
     "contentVersion": "1.0.0.0",
     "parameters": {
         "name": {
-            "value": "jphome1"
+            "value": ""
         },
         "location": {
-            "value": "westeurope"
+            "value": ""
         },
         "defaultDataLakeStorageAccountName": {
-            "value": "jphome1"
+            "value": ""
         },
         "defaultDataLakeStorageFilesystemName": {
-            "value": "workspace"
+            "value": ""
         },
         "sqlAdministratorLogin": {
-            "value": "cloudSA"
+            "value": ""
         },
         "setWorkspaceIdentityRbacOnFilesystem": {
             "value": true
@@ -33,10 +33,10 @@
             "value": "9932f414-50cd-474d-8a1a-bf0649225d73"
         },
         "storageResourceGroupName": {
-            "value": "jphome1"
+            "value": ""
         },
         "storageLocation": {
-            "value": "westeurope"
+            "value": ""
         }
     }
 }
\ No newline at end of file